steveloughran commented on PR #4766: URL: https://github.com/apache/hadoop/pull/4766#issuecomment-1222517838
the last patch factors out stream draining; adds test for corner cases, especially escalation from read to abort. used in classic and prefetching streams, with unit tests. one long-standing aspect of this design is that read(buffer) will swallow any IOE raised on any read() to fill the buffer, *other than the first read()*. so if a socket exception is raised partway through the read, it won't get noticed on that call, but only the subsequent one. need to modify the test to mimic this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
