ahmarsuhail commented on code in PR #4706:
URL: https://github.com/apache/hadoop/pull/4706#discussion_r952789775
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/impl/TestRequestFactory.java:
##########
@@ -170,9 +170,11 @@ private void createFactoryObjects(RequestFactory factory) {
a(factory.newGetObjectRequest(path));
a(factory.newGetObjectMetadataRequest(path));
a(factory.newListMultipartUploadsRequest(path));
- a(factory.newListObjectsV1Request(path, "/", 1));
+ //TODO: Commenting out for now, new request extends AwsRequest, this can
be updated once all
+ // request factory operations are updated.
Review Comment:
have done requestPreparer, this one is slightly more complicated to do as it
needs to return `AWSRequestAnalyzer.RequestInfo`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]