goiri commented on code in PR #4751:
URL: https://github.com/apache/hadoop/pull/4751#discussion_r953999366
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/RMSecretManagerService.java:
##########
@@ -135,9 +135,11 @@ protected RMDelegationTokenSecretManager
createRMDelegationTokenSecretManager(
long tokenRenewInterval =
conf.getLong(YarnConfiguration.RM_DELEGATION_TOKEN_RENEW_INTERVAL_KEY,
YarnConfiguration.RM_DELEGATION_TOKEN_RENEW_INTERVAL_DEFAULT);
-
+ long removeScanInterval =
+
conf.getLong(YarnConfiguration.RM_DELEGATION_TOKEN_REMOVE_SCAN_INTERVAL_KEY,
Review Comment:
We should do getTimeDuration
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml:
##########
@@ -1077,6 +1077,14 @@
<value>86400000</value>
</property>
+ <property>
+ <description>
+ RM delegation token remove-scan interval in ms
+ </description>
+ <name>yarn.resourcemanager.delegation.token.remove-scan-interval</name>
+ <value>3600000</value>
Review Comment:
10h and use time duration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
