[
https://issues.apache.org/jira/browse/HADOOP-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584414#comment-17584414
]
groot commented on HADOOP-16637:
--------------------------------
[~aajisaka] - The PR seems to be closed without any mention of reason. Can you
check if the issues is still existing - if yes, can you please share latest
`Fix findbugs warnings in hadoop-cos`. I can work to fix it. Thanks.
> Fix findbugs warnings in hadoop-cos
> -----------------------------------
>
> Key: HADOOP-16637
> URL: https://issues.apache.org/jira/browse/HADOOP-16637
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/cos
> Reporter: Akira Ajisaka
> Assignee: Yi-Sheng Lien
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> qbt report:
> https://lists.apache.org/thread.html/ab1ea4ac6590061cfb2f89183f33f97e92da0e68e67657dbfbda862f@%3Ccommon-dev.hadoop.apache.org%3E
> {noformat}
> module:hadoop-cloud-storage-project/hadoop-cos
> Redundant nullcheck of dir, which is known to be non-null in
> org.apache.hadoop.fs.cosn.BufferPool.createDir(String) Redundant null check
> at BufferPool.java:is known to be non-null in
> org.apache.hadoop.fs.cosn.BufferPool.createDir(String) Redundant null check
> at BufferPool.java:[line 66]
> org.apache.hadoop.fs.cosn.CosNInputStream$ReadBuffer.getBuffer() may
> expose internal representation by returning CosNInputStream$ReadBuffer.buffer
> At CosNInputStream.java:by returning CosNInputStream$ReadBuffer.buffer At
> CosNInputStream.java:[line 87]
> Found reliance on default encoding in
> org.apache.hadoop.fs.cosn.CosNativeFileSystemStore.storeFile(String, File,
> byte[]):in
> org.apache.hadoop.fs.cosn.CosNativeFileSystemStore.storeFile(String, File,
> byte[]): new String(byte[]) At CosNativeFileSystemStore.java:[line 199]
> Found reliance on default encoding in
> org.apache.hadoop.fs.cosn.CosNativeFileSystemStore.storeFileWithRetry(String,
> InputStream, byte[], long):in
> org.apache.hadoop.fs.cosn.CosNativeFileSystemStore.storeFileWithRetry(String,
> InputStream, byte[], long): new String(byte[]) At
> CosNativeFileSystemStore.java:[line 178]
> org.apache.hadoop.fs.cosn.CosNativeFileSystemStore.uploadPart(File,
> String, String, int) may fail to clean up java.io.InputStream Obligation to
> clean up resource created at CosNativeFileSystemStore.java:fail to clean up
> java.io.InputStream Obligation to clean up resource created at
> CosNativeFileSystemStore.java:[line 252] is not discharged
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
