[ 
https://issues.apache.org/jira/browse/HADOOP-18419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17584481#comment-17584481
 ] 

Steve Vaughan commented on HADOOP-18419:
----------------------------------------

The documentation for Surefire states that this has defaulted to true since 
version 2.12.  I was surprised to see the use of "-Dtest=NoUnitTests" in the 
Hadoop build since I would have expected that to fail.  I actually started 
looking into the Surefire code thinking it must be a special case I didn't 
know.  I can't explain why 3.0.0-M1 wouldn't have complained.

If we want to maintain the ability to filter on non-existent tests, then 
overriding surefire.failIfNoSpecifiedTests to make it false is the correct 
approach

> Don't fail when using -DNoUnitTests
> -----------------------------------
>
>                 Key: HADOOP-18419
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18419
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.4.0
>            Reporter: Steve Vaughan
>            Assignee: Steve Vaughan
>            Priority: Critical
>              Labels: pull-request-available
>
> There are commands in hadoop.sh that use -Dtest=NoUnitTests.  I believe this 
> is intended to replace -DskipTest, by not matching any tests.  This causes an 
> issue since the default for surefire.failIfNoSpecifiedTests is true.
> Updating those commands to override the default will address the issue.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to