snmvaughan opened a new pull request, #4807:
URL: https://github.com/apache/hadoop/pull/4807

   ### Description of PR
   
   This addresses an issue where the plugin's default classpath for executing 
tests fails to include org.junit.platform.launcher.core.LauncherFactory.
   
   It adds `failIfNoSpecifiedTests` defaulted to false, as it is breaking the 
shaded client build and we are a multi module project. 
   if you run `mvn clean test -Dtest=TestDistributedFileSystem` this is 
expected to work
   
   ### How was this patch tested?
   
   Executed locally to replicate the original failure introduced by upgrading 
the plugin:
   ```
   mvn --batch-mode verify -fae --batch-mode -am -pl 
hadoop-client-modules/hadoop-client-check-invariants -pl 
hadoop-client-modules/hadoop-client-check-test-invariants -pl 
hadoop-client-modules/hadoop-client-integration-tests -Dtest=NoUnitTests 
-Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dspotbugs.skip=true
   ```
   
   Running just a specific test across the entire project runs a single test 
without failing:
   ```
   mvn clean test -Dtest=TestDistributedFileSystem
   ```
   
   Running `NoUnitTests` across the entire project runs no tests without 
failing:
   ```
   maven surefire:test -Dtest=NoUnitTests
   ```
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to