zhangshuyan0 commented on PR #4780: URL: https://github.com/apache/hadoop/pull/4780#issuecomment-1228259955
> LGTM. > > Should we add `dfs.namenode.remove.bad.batch.num` to the xml configuration file? Would it be better to add some unit tests? Thanks @slfan1989 , I have added the relevant configuration to the xml file. This patch is mainly to improve the processing performance of HeartbeatManager in large-scale clusters, and has no impact on existing functions, so I did not add a ut. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
