GauthamBanasandra commented on code in PR #4782: URL: https://github.com/apache/hadoop/pull/4782#discussion_r955971687
########## hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists.txt: ########## @@ -28,7 +28,7 @@ project (libhdfspp) cmake_minimum_required(VERSION 2.8) -find_package (Boost 1.72.0 REQUIRED) +find_package (Boost 1.72.0 REQUIRED COMPONENTS date_time) Review Comment: > I'd like to avoid setting this in 4 places. I've now removed the redundant calls to `find_package(Boost ...)`. I'm calling it only in the main `CMakeLists.txt` now. The definitions propagate to the rest of the files where the Boost variables are used since the subordinate `CMakeLists.txt` are invoked from the main `CMakeLists.txt`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
