slfan1989 commented on code in PR #4314:
URL: https://github.com/apache/hadoop/pull/4314#discussion_r956166342
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java:
##########
@@ -134,16 +132,19 @@ public WebAppProxyServlet() {
this.trackingUriPlugins =
conf.getInstances(YarnConfiguration.YARN_TRACKING_URL_GENERATOR,
TrackingUriPlugin.class);
- this.rmAppPageUrlBase =
- StringHelper.pjoin(WebAppUtils.getResolvedRMWebAppURLWithScheme(conf),
- "cluster", "app");
this.failurePageUrlBase =
StringHelper.pjoin(WebAppUtils.getResolvedRMWebAppURLWithScheme(conf),
"cluster", "failure");
- this.ahsAppPageUrlBase =
- StringHelper.pjoin(WebAppUtils.getHttpSchemePrefix(conf)
- + WebAppUtils.getAHSWebAppURLWithoutScheme(conf),
- "applicationhistory", "app");
+ }
+
+ private String getRmAppPageUrlBase(ApplicationId id) throws YarnException,
IOException {
+ return ((AppReportFetcher)
getServletContext().getAttribute(WebAppProxy.FETCHER_ATTRIBUTE))
Review Comment:
For example, it can be extracted here to make the code easier to read. I
think the first way you provide is feasible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
