slfan1989 commented on code in PR #4764:
URL: https://github.com/apache/hadoop/pull/4764#discussion_r956480233
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/FederationClientInterceptor.java:
##########
@@ -1614,13 +1782,41 @@ protected SubClusterId getApplicationHomeSubCluster(
} catch (Exception ex) {
if(LOG.isDebugEnabled()){
- LOG.debug("Can't Find ApplicationId = {} in Sub Cluster!",
applicationId);
+ LOG.debug("Can't find applicationId = {} in Sub Cluster!",
applicationId);
}
}
}
String errorMsg =
- String.format("Can't Found applicationId = %s in any sub clusters",
applicationId);
+ String.format("Can't find applicationId = %s in any sub clusters",
applicationId);
+ throw new YarnException(errorMsg);
+ }
+
+ protected SubClusterId getReservationHomeSubCluster(ReservationId
reservationId)
+ throws YarnException {
+
+ if (reservationId == null) {
+ LOG.error("ReservationId is Null, Can't find in SubCluster.");
+ return null;
+ }
+
+ SubClusterId resultSubClusterId = null;
+
+ // try looking for reservation in Home SubCluster
+ try {
+ resultSubClusterId =
federationFacade.getReservationHomeSubCluster(reservationId);
+ } catch (YarnException ex) {
+ if(LOG.isDebugEnabled()){
Review Comment:
I will modify the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
