[
https://issues.apache.org/jira/browse/HADOOP-18133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17586103#comment-17586103
]
ASF GitHub Bot commented on HADOOP-18133:
-----------------------------------------
GauthamBanasandra commented on code in PR #4765:
URL: https://github.com/apache/hadoop/pull/4765#discussion_r956605775
##########
dev-support/jenkins.sh:
##########
@@ -224,6 +224,18 @@ function github_status_recovery() {
/usr/bin/env bash "${TESTPATCHBIN}" "${YETUS_ARGS[@]}" "${EXTRA_ARGS}" ||
true
}
+## @description Returns a comma-separated list of the plugins to be run by
Yetus
+function get_plugin_exclusions() {
+ excludedPlugins="-jira"
+
+ # Do not run hadolint for Windows since all the commands are either
Powershell or CMD
+ if [[ "$DOCKERFILE" == "Dockerfile_windows_10" ]]; then
+ excludedPlugins="${excludedPlugins},-hadolint"
+ fi
+
+ echo ",${excludedPlugins}"
Review Comment:
That's right. I was able to get the hadolint working for
`Dockerfile_windows_10` by upgrading the hadolint version, that way, we don't
have to worry about disabling it.
> Add Dockerfile for Windows 10
> -----------------------------
>
> Key: HADOOP-18133
> URL: https://issues.apache.org/jira/browse/HADOOP-18133
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.4.0
> Environment: Windows 10
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Critical
> Labels: pull-request-available
>
> Need to write a Dockerfile for Windows 10 that creates a Docker image for
> building Hadoop on the Windows 10 platform.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
