GauthamBanasandra opened a new pull request, #4815:
URL: https://github.com/apache/hadoop/pull/4815
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
The `winutils`, `libwinutils` and `native` project structures are currently
defined in `.vcxproj` and `.sln` files. For building on Windows using Visual
Studio, a key parameter is the `PlatformToolsetVersion`. This gets added by the
build system by running
[dev-support/bin/win-vs-upgrade.cmd](https://github.com/apache/hadoop/blob/c60a900583d6a8d0494980f4bbbf4f95438b741b/dev-support/bin/win-vs-upgrade.cmd).
This essentially runs the following command to detect the
PlatformToolsetVersion of the currently installed Visual Studio and uses the
same for compilation -
https://github.com/apache/hadoop/blob/c60a900583d6a8d0494980f4bbbf4f95438b741b/dev-support/bin/win-vs-upgrade.cmd#L38
However, when building with `Dockerfile_windows_10`, only Visual Studio 2019
Build Tools are available (**and not the full IDE**). The Visual Studio 2019
Build Tools distribution doesn't contain `devenv` and thus, the above command
fails to run stating that it couldn't find devenv.
To fix this issue, this PR adds the ability to specify the
PlatformToolsetVersion as a Maven option `use.platformToolsetVersion`, at which
point the win-vs-upgrade.cmd won't run and would use the speicified
PlatformToolsetVersion against MSBuild.
### How was this patch tested?
Tested by compiling Hadoop locally.
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
