[
https://issues.apache.org/jira/browse/HADOOP-18391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17597151#comment-17597151
]
ASF GitHub Bot commented on HADOOP-18391:
-----------------------------------------
steveloughran commented on code in PR #4787:
URL: https://github.com/apache/hadoop/pull/4787#discussion_r957189351
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/functional/Function4RaisingIOE.java:
##########
@@ -0,0 +1,8 @@
+package org.apache.hadoop.util.functional;
+
+import java.io.IOException;
+
+public interface Function4RaisingIOE<I1, I2, I3, I4> {
Review Comment:
add a return type, R, as last arg, so it actually becomes a function.
> Improve VectoredReadUtils
> -------------------------
>
> Key: HADOOP-18391
> URL: https://issues.apache.org/jira/browse/HADOOP-18391
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 3.3.9
> Reporter: Steve Loughran
> Assignee: Mukund Thakur
> Priority: Major
> Labels: pull-request-available
>
> harden the VectoredReadUtils methods for consistent and more robust use,
> especially in those filesystems which don't have the api.
> VectoredReadUtils.readInDirectBuffer should allocate a max buffer size, .e.g
> 4mb, then do repeated reads and copies; this ensures that you don't OOM with
> many threads doing ranged requests. other libs do this.
> readVectored to call validateNonOverlappingAndReturnSortedRanges before
> iterating
> this ensures the abfs/s3a requirements are always met, and that because
> ranges will be read in order, prefetching by other clients will keep their
> performance good.
> readVectored to add special handling for 0 byte ranges
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
