goiri commented on code in PR #4814: URL: https://github.com/apache/hadoop/pull/4814#discussion_r957551298
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/uam/UnmanagedAMPoolManager.java: ########## @@ -501,4 +472,51 @@ public Map<String, FinishApplicationMasterResponse> batchFinishApplicationMaster return responseMap; } + + Runnable createForceFinishApplicationThread() { + return () -> { + + ExecutorCompletionService<KillApplicationResponse> completionService = + new ExecutorCompletionService<>(threadpool); + + // Save a local copy of the key set so that it won't change with the map + Set<String> addressList = new HashSet<>(unmanagedAppMasterMap.keySet()); + + LOG.warn("Abnormal shutdown of UAMPoolManager, still {} UAMs in map", addressList.size()); + + for (final String uamId : addressList) { + completionService.submit(() -> { + try { + ApplicationId appId = appIdMap.get(uamId); + LOG.info("Force-killing UAM id {} for application {}", uamId, appId); + return unmanagedAppMasterMap.remove(uamId).forceKillApplication(); + } catch (Exception e) { + LOG.error("Failed to kill unmanaged application master", e); + return null; + } + }); + } + + for (int i = 0; i < addressList.size(); ++i) { + try { + Future<KillApplicationResponse> future = completionService.take(); + future.get(); Review Comment: We don't check for anything? ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/uam/TestUnmanagedApplicationManager.java: ########## @@ -58,6 +64,9 @@ public class TestUnmanagedApplicationManager { private ApplicationAttemptId attemptId; + private UnmanagedAMPoolManager uamPool; + private ExecutorService threadpool; Review Comment: Clean this? ########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/uam/TestUnmanagedApplicationManager.java: ########## @@ -58,6 +64,9 @@ public class TestUnmanagedApplicationManager { private ApplicationAttemptId attemptId; + private UnmanagedAMPoolManager uamPool; + private ExecutorService threadpool; Review Comment: stop() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org