slfan1989 commented on code in PR #4817:
URL: https://github.com/apache/hadoop/pull/4817#discussion_r957975795
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/SQLFederationStateStore.java:
##########
@@ -1016,30 +1035,275 @@ private static byte[] getByteArray(ByteBuffer bb) {
@Override
public AddReservationHomeSubClusterResponse addReservationHomeSubCluster(
Review Comment:
Thank you for your suggestion.
I will explain this part of the test:
In YARN-11272, we implemented store Reservations in ZK, in this
pr(https://github.com/apache/hadoop/pull/4781) we defined the test of the
method in FederationStateStoreBaseTest.java
```
testAddReservationHomeSubCluster()
testAddReservationHomeSubClusterReservationAlreadyExists()
testAddReservationHomeSubClusterAppAlreadyExistsInTheSameSC()
testDeleteReservationHomeSubCluster()
testDeleteReservationHomeSubClusterUnknownApp()
testUpdateReservationHomeSubCluster()
```
Because TestSQLFederationStateStore extends FederationStateStoreBaseTest, we
can reuse YARN-11272 tests, and of course we will add some tests.
Can you help merge YARN-11272(#4781) into trunk branch? Thank you very much！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
