ashutoshcipher commented on PR #4816: URL: https://github.com/apache/hadoop/pull/4816#issuecomment-1232900544
> Hi @ashutoshcipher thanks for the contribution! The change looks good to me, however I have one request. We would need some test on cases where the key is longer than 64 bits. Perhaps the default value should be 256? Thanks @9uapaw for reviewing. The original value at 64, so I kept default as 64 but I will change it 256 as per you suggestion. On test-case side, can you share give some suggestion how to check that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
