slfan1989 commented on code in PR #4836:
URL: https://github.com/apache/hadoop/pull/4836#discussion_r961293032
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/FederationInterceptor.java:
##########
@@ -770,18 +771,26 @@ public FinishApplicationMasterResponse
finishApplicationMaster(
if (failedToUnRegister) {
homeResponse.setIsUnregistered(false);
- } else {
+ } else if (checkRequestFinalApplicationStatusSuccess(request)) {
// Clean up UAMs only when the app finishes successfully, so that no more
// attempt will be launched.
this.uamPool.stop();
- if (this.registryClient != null) {
- this.registryClient
- .removeAppFromRegistry(this.attemptId.getApplicationId());
- }
+ removeAppFromRegistry();
}
return homeResponse;
}
+ private boolean
checkRequestFinalApplicationStatusSuccess(FinishApplicationMasterRequest
request) {
+ if (request == null) {
+ return false;
+ } else if(request.getFinalApplicationStatus() == null){
Review Comment:
Thank you very much for helping to review the code, I will modify the code!
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/FederationInterceptor.java:
##########
@@ -770,18 +771,26 @@ public FinishApplicationMasterResponse
finishApplicationMaster(
if (failedToUnRegister) {
homeResponse.setIsUnregistered(false);
- } else {
+ } else if (checkRequestFinalApplicationStatusSuccess(request)) {
// Clean up UAMs only when the app finishes successfully, so that no more
// attempt will be launched.
this.uamPool.stop();
- if (this.registryClient != null) {
- this.registryClient
- .removeAppFromRegistry(this.attemptId.getApplicationId());
- }
+ removeAppFromRegistry();
}
return homeResponse;
}
+ private boolean
checkRequestFinalApplicationStatusSuccess(FinishApplicationMasterRequest
request) {
+ if (request == null) {
+ return false;
+ } else if(request.getFinalApplicationStatus() == null){
Review Comment:
Thank you very much for helping to review the code, I will modify the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
