[ 
https://issues.apache.org/jira/browse/HADOOP-18449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602701#comment-17602701
 ] 

ASF GitHub Bot commented on HADOOP-18449:
-----------------------------------------

hadoop-yetus commented on PR #4876:
URL: https://github.com/apache/hadoop/pull/4876#issuecomment-1242718347

   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 53s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +0 :ok: |  yamllint  |   0m  0s |  |  yamllint was not available.  |
   | +0 :ok: |  shellcheck  |   0m  0s |  |  Shellcheck was not available.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  |  The patch appears to 
include 1 new or modified test files.  |
   |||| _ trunk Compile Tests _ |
   | +0 :ok: |  mvndep  |  14m 33s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  29m 22s |  |  trunk passed  |
   | +1 :green_heart: |  mvnsite  |  20m  4s |  |  trunk passed  |
   | +1 :green_heart: |  shadedclient  |  41m 44s |  |  branch has no errors 
when building and testing our client artifacts.  |
   |||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 25s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  26m 12s |  |  the patch passed  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks 
issues.  |
   | +1 :green_heart: |  hadolint  |   0m  2s |  |  The patch generated 0 new + 
0 unchanged - 41 fixed = 0 total (was 41)  |
   | +1 :green_heart: |  mvnsite  |  19m 46s |  |  the patch passed  |
   | +1 :green_heart: |  shadedclient  |  41m 45s |  |  patch has no errors 
when building and testing our client artifacts.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  unit  |  21m 56s |  |  root in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   1m 10s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   | 179m 48s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4876/2/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/4876 |
   | Optional Tests | dupname asflicense codespell detsecrets yamllint hadolint 
shellcheck shelldocs mvnsite unit shadedclient |
   | uname | Linux 5f895caf7393 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 
01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/bin/hadoop.sh |
   | git revision | trunk / 383c6a2410d208e97b646af11af7289a4a4d6cd8 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4876/2/testReport/ |
   | Max. process+thread count | 608 (vs. ulimit of 5500) |
   | modules | C: hadoop-client-modules/hadoop-client-check-invariants . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4876/2/console |
   | versions | git=2.9.5 maven=3.6.3 hadolint=2.10.0 |
   | Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Upgrade hadolint to 2.10.0
> --------------------------
>
>                 Key: HADOOP-18449
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18449
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.4.0
>            Reporter: Gautham Banasandra
>            Assignee: Gautham Banasandra
>            Priority: Major
>              Labels: pull-request-available
>
> The current version of hadolint (1.11.1) is only suitable for linting Linux 
> commands in Dockerfile. It fails to recognize Windows command syntax.
> HADOOP-18133 adds Dockerfile for Windows. Thus, it's essential to upgrade 
> hadolint to 2.10.0 which has the ability to recognize Windows command syntax.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to