[ 
https://issues.apache.org/jira/browse/HADOOP-18451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17603797#comment-17603797
 ] 

ASF GitHub Bot commented on HADOOP-18451:
-----------------------------------------

slfan1989 commented on PR #4880:
URL: https://github.com/apache/hadoop/pull/4880#issuecomment-1246014091

   > I am not aware of any such issue which can bother us, went through the 
release notes and all, everything looks sorted. Though there is one regression: 
https://sourceforge.net/p/hsqldb/bugs/1641/#864f in 2.5.2 from 2.5.1, something 
around NULL check, but I don't think we have any such queries and it does seems 
to have a workaround as well. So should be safe..
   > 
   > The only test failure is TestKMS, fails with & without the patch. Most 
probably broken by 
[HADOOP-18427](https://issues.apache.org/jira/browse/HADOOP-18427), tried 
reverting locally and it passed.
   
   Thank you very much for your suggestion, this upgrade is mainly because you 
need to use SQLServer level mode, such as support for data type DATETIME2, 
Junit Test of TestKMS failed, I will check and fix it as soon as possible.




> Update hsqldb.version from 2.3.4 to 2.5.2
> -----------------------------------------
>
>                 Key: HADOOP-18451
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18451
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common
>    Affects Versions: 3.4.0
>            Reporter: fanshilun
>            Assignee: fanshilun
>            Priority: Major
>              Labels: pull-request-available
>
> I plan to upgrade the version of hsqldb from 2.3.4 to 2.5.2 for the following 
> reasons:
> 1.Current version 2.3.4 is almost ~6 years old,Upgrading to new release to 
> keep up for new features and bug fixes.
> 2.I plan to increase the verification of the table building statement, which 
> needs to use the compatibility mode of Mysql and SqlServer. 
> The 2.5.2 version of hsqldb does better.
> 3.We are temporarily unable to upgrade hsqldb to version 2.6.0 because 
> version 2.6.0 depends on JDK11.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to