goiri commented on code in PR #4890:
URL: https://github.com/apache/hadoop/pull/4890#discussion_r972200934
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java:
##########
@@ -1327,8 +1327,8 @@ private void refreshHostsReader(Configuration conf)
throws IOException {
// Update the file names and refresh internal includes and excludes list.
if (conf == null) {
conf = new HdfsConfiguration();
- this.hostConfigManager.setConf(conf);
}
+ this.hostConfigManager.setConf(conf);
Review Comment:
Can we add a test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
