[
https://issues.apache.org/jira/browse/HADOOP-18457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17606912#comment-17606912
]
ASF GitHub Bot commented on HADOOP-18457:
-----------------------------------------
anmolanmol1234 commented on code in PR #4907:
URL: https://github.com/apache/hadoop/pull/4907#discussion_r974899360
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClientThrottlingInterceptFactory.java:
##########
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.azurebfs.services;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+final class AbfsClientThrottlingInterceptFactory {
+
+ private AbfsClientThrottlingInterceptFactory() {
+ }
+
+ private static final Logger LOG = LoggerFactory.getLogger(
+ AbfsClientThrottlingInterceptFactory.class);
+
+ private static Map<String, AbfsClientThrottlingIntercept> instanceMapping
+ = new ConcurrentHashMap<>();
+
+ static synchronized AbfsClientThrottlingIntercept getInstance(String
accountName,
+ boolean isAutoThrottlingEnabled,
+ boolean isSingletonEnabled) {
+ AbfsClientThrottlingIntercept instance;
+ if (isSingletonEnabled) {
+ instance = AbfsClientThrottlingIntercept.initializeSingleton(
+ isAutoThrottlingEnabled);
+ } else {
+ if (!isAutoThrottlingEnabled) {
+ return null;
+ }
+ if (instanceMapping.get(accountName) == null) {
+ LOG.debug("The accountName is: {} ", accountName);
+ instance = new AbfsClientThrottlingIntercept(accountName);
+ instanceMapping.put(accountName, instance);
Review Comment:
The method getInstance is a synchronized method and the instanceMapping map
is also a concurrent hash map. We are also checking for null in line no 49, so
race condition is ideally not possible here.
> ABFS: Support for account level throttling
> ------------------------------------------
>
> Key: HADOOP-18457
> URL: https://issues.apache.org/jira/browse/HADOOP-18457
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.3.4
> Reporter: Anmol Asrani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> To add support for throttling at account level
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
