goiri commented on code in PR #4915:
URL: https://github.com/apache/hadoop/pull/4915#discussion_r978168499
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/MemoryFederationStateStore.java:
##########
@@ -459,6 +416,71 @@ public RouterMasterKeyResponse
getMasterKeyByDelegationKey(RouterMasterKeyReques
return RouterMasterKeyResponse.newInstance(resultRouterMasterKey);
}
+ @Override
+ public RouterRMTokenResponse storeNewToken(RouterRMTokenRequest request)
+ throws YarnException, IOException {
+ RouterStoreToken storeToken = request.getRouterStoreToken();
+ RMDelegationTokenIdentifier tokenIdentifier =
+ (RMDelegationTokenIdentifier) storeToken.getTokenIdentifier();
Review Comment:
Indentation or single line.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/SQLFederationStateStore.java:
##########
@@ -40,50 +40,7 @@
import org.apache.hadoop.yarn.server.federation.store.FederationStateStore;
import
org.apache.hadoop.yarn.server.federation.store.exception.FederationStateStoreInvalidInputException;
import
org.apache.hadoop.yarn.server.federation.store.metrics.FederationStateStoreClientMetrics;
-import
org.apache.hadoop.yarn.server.federation.store.records.AddApplicationHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.AddApplicationHomeSubClusterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.ApplicationHomeSubCluster;
-import
org.apache.hadoop.yarn.server.federation.store.records.DeleteApplicationHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.DeleteApplicationHomeSubClusterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetApplicationHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetApplicationHomeSubClusterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetApplicationsHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetApplicationsHomeSubClusterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetSubClusterInfoRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetSubClusterInfoResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetSubClusterPoliciesConfigurationsRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetSubClusterPoliciesConfigurationsResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetSubClusterPolicyConfigurationRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetSubClusterPolicyConfigurationResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetSubClustersInfoRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetSubClustersInfoResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.SetSubClusterPolicyConfigurationRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.SetSubClusterPolicyConfigurationResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.SubClusterDeregisterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.SubClusterDeregisterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.SubClusterHeartbeatRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.SubClusterHeartbeatResponse;
-import org.apache.hadoop.yarn.server.federation.store.records.SubClusterId;
-import org.apache.hadoop.yarn.server.federation.store.records.SubClusterInfo;
-import
org.apache.hadoop.yarn.server.federation.store.records.SubClusterPolicyConfiguration;
-import
org.apache.hadoop.yarn.server.federation.store.records.SubClusterRegisterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.SubClusterRegisterResponse;
-import org.apache.hadoop.yarn.server.federation.store.records.SubClusterState;
-import
org.apache.hadoop.yarn.server.federation.store.records.UpdateApplicationHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.UpdateApplicationHomeSubClusterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.AddReservationHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.AddReservationHomeSubClusterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetReservationHomeSubClusterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetReservationHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetReservationsHomeSubClusterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetReservationsHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.DeleteReservationHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.DeleteReservationHomeSubClusterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.UpdateReservationHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.UpdateReservationHomeSubClusterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.ReservationHomeSubCluster;
-import
org.apache.hadoop.yarn.server.federation.store.records.RouterMasterKeyRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.RouterMasterKeyResponse;
+import org.apache.hadoop.yarn.server.federation.store.records.*;
Review Comment:
Avoid
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/SQLFederationStateStore.java:
##########
@@ -1406,4 +1363,28 @@ public RouterMasterKeyResponse
getMasterKeyByDelegationKey(RouterMasterKeyReques
throws YarnException, IOException {
throw new NotImplementedException("Code is not implemented");
}
+
+ @Override
+ public RouterRMTokenResponse storeNewToken(RouterRMTokenRequest request)
+ throws YarnException, IOException {
+ throw new NotImplementedException("Code is not implemented");
Review Comment:
Tests that would catch this?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/federation/store/impl/MemoryFederationStateStore.java:
##########
@@ -31,55 +31,12 @@
import org.apache.hadoop.classification.VisibleForTesting;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.security.token.delegation.DelegationKey;
+import org.apache.hadoop.yarn.security.client.RMDelegationTokenIdentifier;
import org.apache.hadoop.yarn.api.records.ApplicationId;
import org.apache.hadoop.yarn.api.records.ReservationId;
import org.apache.hadoop.yarn.exceptions.YarnException;
import org.apache.hadoop.yarn.server.federation.store.FederationStateStore;
-import
org.apache.hadoop.yarn.server.federation.store.records.AddApplicationHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.AddApplicationHomeSubClusterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.ApplicationHomeSubCluster;
-import
org.apache.hadoop.yarn.server.federation.store.records.DeleteApplicationHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.DeleteApplicationHomeSubClusterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetApplicationHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetApplicationHomeSubClusterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetApplicationsHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetApplicationsHomeSubClusterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetSubClusterInfoRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetSubClusterInfoResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetSubClusterPoliciesConfigurationsRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetSubClusterPoliciesConfigurationsResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetSubClusterPolicyConfigurationRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetSubClusterPolicyConfigurationResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetSubClustersInfoRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetSubClustersInfoResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.SetSubClusterPolicyConfigurationRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.SetSubClusterPolicyConfigurationResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.SubClusterDeregisterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.SubClusterDeregisterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.SubClusterHeartbeatRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.SubClusterHeartbeatResponse;
-import org.apache.hadoop.yarn.server.federation.store.records.SubClusterId;
-import org.apache.hadoop.yarn.server.federation.store.records.SubClusterInfo;
-import
org.apache.hadoop.yarn.server.federation.store.records.SubClusterPolicyConfiguration;
-import
org.apache.hadoop.yarn.server.federation.store.records.SubClusterRegisterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.SubClusterRegisterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.UpdateApplicationHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.UpdateApplicationHomeSubClusterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.AddReservationHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.AddReservationHomeSubClusterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetReservationHomeSubClusterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetReservationHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetReservationsHomeSubClusterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.GetReservationsHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.ReservationHomeSubCluster;
-import
org.apache.hadoop.yarn.server.federation.store.records.UpdateReservationHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.UpdateReservationHomeSubClusterResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.DeleteReservationHomeSubClusterRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.DeleteReservationHomeSubClusterResponse;
-import org.apache.hadoop.yarn.server.federation.store.records.RouterMasterKey;
-import
org.apache.hadoop.yarn.server.federation.store.records.RouterMasterKeyRequest;
-import
org.apache.hadoop.yarn.server.federation.store.records.RouterMasterKeyResponse;
-import
org.apache.hadoop.yarn.server.federation.store.records.RouterRMDTSecretManagerState;
+import org.apache.hadoop.yarn.server.federation.store.records.*;
Review Comment:
Avoid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
