steveloughran commented on PR #4937:
URL: https://github.com/apache/hadoop/pull/4937#issuecomment-1269707239
lgtm. +1 pending the checkstyle fixes, which are just line length
```
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java:339:
assertEquals(prettyPrintJson(getResourceAsString(expectedResourceFilename)),
prettyPrintJson(actual));: Line is longer than 100 characters (found 106).
[LineLength]
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySched.java:344:
return
objectMapper.writerWithDefaultPrettyPrinter().writeValueAsString(objectMapper.readTree(in));:
Line is longer than 100 characters (found 103). [LineLength]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
