dannycjones commented on code in PR #4925:
URL: https://github.com/apache/hadoop/pull/4925#discussion_r989065662
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/AbstractTestS3AEncryption.java:
##########
@@ -78,6 +78,14 @@ protected void patchConfigurationEncryptionSettings(
0, 1, 2, 3, 4, 5, 254, 255, 256, 257, 2 ^ 12 - 1
};
+ /**
+ * Skips the tests if encryption is not enabled in configuration.
+ *
+ * @implNote We can use {@link #createConfiguration()} here since
Review Comment:
I never realised they weren't JavaDoc standard tags.
I'm not really fussed either way, I can move to an inline comment really.
Just as a note, if this was in `public` src code then I think builds would
fail with something like this:
```
[ERROR]
hadoop/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/impl/LoggingAuditor.java:61:
error: unknown tag: myTag
[ERROR] * @myTag What happens if I build this?
```
Happy to move it to inline comment in `trunk` - let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
