goiri commented on code in PR #4960:
URL: https://github.com/apache/hadoop/pull/4960#discussion_r989248515
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java:
##########
@@ -129,6 +129,12 @@ protected Boolean hasAccess(RMApp app, HttpServletRequest
hsr) {
return true;
}
+ public String printAppInfo(long appInfoFunc) {
+ if (appInfoFunc== -1) {
Review Comment:
Space before ==
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/FairSchedulerAppsBlock.java:
##########
@@ -129,6 +129,12 @@ protected Boolean hasAccess(RMApp app, HttpServletRequest
hsr) {
return true;
}
+ public String printAppInfo(long appInfoFunc) {
Review Comment:
make it private and static.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
