xinglin commented on PR #4872: URL: https://github.com/apache/hadoop/pull/4872#issuecomment-1272459124
Hi @ZanderXu, I understand what you tried to do now. The first `checkOperation(OperationCategory.WRITE)` call will throw a `RetryOnActiveException` on an observerNN. Are you aware why there are multiple `checkOperation()` in this function? I'd assume a single `checkOperation(OperationCategory.WRITE)` at the beginning of this function should be sufficient? Why are there checks for both READ and WRITE and why do we check for READ/writes twice (one before getting the lock and the one after getting the lock)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
