steveloughran commented on code in PR #4973:
URL: https://github.com/apache/hadoop/pull/4973#discussion_r991486622
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java:
##########
@@ -640,7 +640,8 @@ public static AWSCredentialProviderList
buildAWSProviderList(
AWSCredentialProviderList providers = new AWSCredentialProviderList();
for (Class<?> aClass : awsClasses) {
- if (aClass.getName().contains(AWS_AUTH_CLASS_PREFIX)) {
+ if
(!aClass.getSimpleName().equals("EnvironmentVariableCredentialsProvider")
Review Comment:
how about having an array of simple names to skip on, with that,
EC2ContainerCredentialsProviderWrapper, and InstanceProfileCredentialsProvider
in. we only added our own IAMInstanceCredentialsProvider with delegation
tokens, HADOOP-15449, and until then just included the aws sdk one directly.
any refs to either can be mapped to IAMInstanceCredentialsProvider before
trying to instantiate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
