steveloughran commented on code in PR #4966:
URL: https://github.com/apache/hadoop/pull/4966#discussion_r992153111
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3A.java:
##########
@@ -54,4 +55,13 @@ public String toString() {
sb.append('}');
return sb.toString();
}
+
+ /**
+ * Close the file system; the FileContext API doesn't have an explicit close.
+ */
+ @Override
+ protected void finalize() throws Throwable {
Review Comment:
one fix would be for FileContext to be closeable and so trigger cleanups
without hoping finalize() gets called, especially as GC is triggered by heap
use, and i don't know if thread count does that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
