mccormickt12 commented on code in PR #4967:
URL: https://github.com/apache/hadoop/pull/4967#discussion_r992950901
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/ClientNamenodeProtocol.proto:
##########
@@ -428,6 +428,14 @@ message GetPreferredBlockSizeResponseProto {
message GetSlowDatanodeReportRequestProto {
}
+message GetEnclosingRootRequestProto {
+ required string filename = 1;
Review Comment:
sounds good. Ill update these to `optional` since it is best practice for
proto going forward and hadoop doesn't seem to be super opinionated about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
