dannycjones commented on code in PR #4965:
URL: https://github.com/apache/hadoop/pull/4965#discussion_r993296672
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/tools/MarkerTool.java:
##########
@@ -960,43 +960,64 @@ public static final class ScanArgsBuilder {
/** Consider only markers in nonauth paths as errors. */
private boolean nonAuth = false;
- /** Source FS; must be or wrap an S3A FS. */
+ /** Source FS; must be or wrap an S3A FS.
Review Comment:
>Let's not change the check style as yes it will flag many issues.
It will flag issues, but maybe worth it to avoid needing to add this sort of
feedback in future.
Let Yetus tell us before we review.
If we were to consider it, I'd propose to do it:
- In a separate PR / task so we can acknowledge "yes this is adding new
warnings".
- Only for `hadoop-aws` module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
