FuzzingTeam commented on PR #5001:
URL: https://github.com/apache/hadoop/pull/5001#issuecomment-1278063976
Thanks, @ZanderXu, for the review.
I researched if the XORRawDecoder can decode multiple erased indexes, and I
found that XORRawDecoder can generate only 1 parity bit, implying the erased
indexes to be either 1 or 0.
One thing that surprises me is how the test method testValidate() passes on
the newly added value set (numParityUnits = 3). The passing of the method means
that XORRawDecoder could decode multiple erased indexes, which contradicts the
actual statement.
I propose that we could either investigate and fix the testValidate() method
or add the below check to run before each test:
if (encoderFactoryClass == XORRawErasureCoderFactory.class) {
Assume.assumeTrue(numParityUnits == 1);
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
