jianghuazhu commented on code in PR #5013:
URL: https://github.com/apache/hadoop/pull/5013#discussion_r995305422
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java:
##########
@@ -249,7 +249,7 @@ static RenameResult renameToInt(
String dst = dstArg;
if (NameNode.stateChangeLog.isDebugEnabled()) {
NameNode.stateChangeLog.debug("DIR* NameSystem.renameTo: with options -"
+
- " " + src + " to " + dst);
+ " {} to {}, options={}", src, dst, Arrays.toString(options));
Review Comment:
I agree.
Here are some audit logs:
`
2022-10-14 11:16:30,825 [Listener at localhost/51113] INFO
FSNamesystem.audit (FSNamesystem.java:logAuditMessage(8853)) - allowed=true
ugi=hdfs (auth:SIMPLE) ip=null cmd=rename ( options=[NONE])
src=/testNamenodeRetryCache/testRename2/src
dst=/testNamenodeRetryCache/testRename2/target perm=hdfs:supergroup:rwxrwxrwx
proto=null
`
Should we keep a consistent norm?
New format:
`
2022-10-14 11:20:18,813 [Listener at localhost/58086] DEBUG
hdfs.StateChange(FSDirRenameOp.java:renameToInt(256)) - DIR*
NameSystem.renameTo: with options=[NONE]
/testNamenodeRetryCache/testRename2/src to /testNamenodeRetryCache
/testRename2/target
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
