steveloughran commented on code in PR #4965:
URL: https://github.com/apache/hadoop/pull/4965#discussion_r997313826
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/DirMarkerTracker.java:
##########
@@ -34,20 +34,20 @@
* Tracks directory markers which have been reported in object listings.
* This is needed for auditing and cleanup, including during rename
* operations.
- * <p></p>
+ * <p>
Review Comment:
these are all good
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/tools/MarkerTool.java:
##########
@@ -840,6 +846,7 @@ public void setVerbose(final boolean verbose) {
* Execute the marker tool, with no checks on return codes.
*
* @param scanArgs set of args for the scanner.
+ * @throws IOException IO failure
Review Comment:
can you put this below the @return line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
