Willi Raschkowski created HADOOP-18500:
------------------------------------------

             Summary: Upgrade maven-shade-plugin to 3.3.0
                 Key: HADOOP-18500
                 URL: https://issues.apache.org/jira/browse/HADOOP-18500
             Project: Hadoop Common
          Issue Type: Improvement
          Components: build
            Reporter: Willi Raschkowski


Maven-shade-plugin rewrites classes when moving them into {{hadoop-client}} 
JARs. That's true even when it doesn't actually need to modify the byte code of 
the classes, say for shading.

We use a tool that checks for classpath duplicates that don't have equal byte 
codes. We noticed that it flags classes brought in via Hadoop, where one JAR 
containing them is {{hadoop-client-api}} and {{hadoop-client-runtime}}, and the 
other JAR is {{hadoop-common}} or {{hadoop-shaded-guava}}. The byte code for 
the same class is indeed different between the relocated and non-relocated JARs.

This is because maven-shade-plugin, before 3.3.0, was rewriting class files 
even when the relocation was a "no-op". See MSHADE-391 and 
[apache/maven-shade-plugin#95|https://github.com/apache/maven-shade-plugin/pull/95].



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to