steveloughran commented on code in PR #5051:
URL: https://github.com/apache/hadoop/pull/5051#discussion_r1001606180


##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AProxy.java:
##########
@@ -35,11 +36,11 @@
 import static org.apache.hadoop.fs.s3a.S3AUtils.initProxySupport;
 
 /**
- * Unit tests to verify {@link S3AUtils} translates the proxy configurations
+ * Tests to verify {@link S3AUtils} translates the proxy configurations
  * are set correctly to Client configurations which are later used to construct
  * the proxy in AWS SDK.
  */
-public class TestS3AProxy extends AbstractS3ATestBase{
+public class ITestS3AProxy extends AbstractHadoopTestBase {

Review Comment:
   sorry, i was confusing you. the old code was implicitly and ITest because it 
extended S3ATestBase; with the changed superclass it is a unit test, so can be 
renamed to the original name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to