[ 
https://issues.apache.org/jira/browse/HADOOP-18499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622165#comment-17622165
 ] 

ASF GitHub Bot commented on HADOOP-18499:
-----------------------------------------

steveloughran commented on code in PR #5051:
URL: https://github.com/apache/hadoop/pull/5051#discussion_r1001606180


##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AProxy.java:
##########
@@ -35,11 +36,11 @@
 import static org.apache.hadoop.fs.s3a.S3AUtils.initProxySupport;
 
 /**
- * Unit tests to verify {@link S3AUtils} translates the proxy configurations
+ * Tests to verify {@link S3AUtils} translates the proxy configurations
  * are set correctly to Client configurations which are later used to construct
  * the proxy in AWS SDK.
  */
-public class TestS3AProxy extends AbstractS3ATestBase{
+public class ITestS3AProxy extends AbstractHadoopTestBase {

Review Comment:
   sorry, i was confusing you. the old code was implicitly and ITest because it 
extended S3ATestBase; with the changed superclass it is a unit test, so can be 
renamed to the original name





> S3A to support setting proxy protocol
> -------------------------------------
>
>                 Key: HADOOP-18499
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18499
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/s3
>            Reporter: Mehakmeet Singh
>            Assignee: Mehakmeet Singh
>            Priority: Major
>              Labels: pull-request-available
>
> Currently, we cannot set the protocol for a proxy in S3A. The proxy protocol 
> is set to "http" by default and thus we lack the support for HTTPS proxy in 
> S3A.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to