[
https://issues.apache.org/jira/browse/HADOOP-18506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622743#comment-17622743
]
ASF GitHub Bot commented on HADOOP-18506:
-----------------------------------------
GauthamBanasandra commented on code in PR #5066:
URL: https://github.com/apache/hadoop/pull/5066#discussion_r1002660354
##########
BUILDING.txt:
##########
@@ -557,6 +586,22 @@ the zlib 1.2.7 source tree.
http://www.zlib.net/
+
+Build command:
+The following command builds all the modules in the Hadoop project and
generates the tar.gz file in
+hadoop-dist/target upon successful build. Run these commands from an
+"x64 Native Tools Command Prompt for VS 2019" which can be found under "Visual
Studio 2019" in the
+Windows start menu.
+
+> set classpath=
Review Comment:
Right, but this file (`BUILDING.txt`) isn't rendered as markdown. It
should've been `BUILDING.md`.
I'm using the `>` at the beginning to signify the start of the command in a
Windows terminal. Like -
##########
BUILDING.txt:
##########
@@ -492,39 +492,63 @@ Building on CentOS 8
----------------------------------------------------------------------------------
-Building on Windows
+Building on Windows 10
----------------------------------------------------------------------------------
Requirements:
-* Windows System
+* Windows 10
* JDK 1.8
* Maven 3.0 or later
* Boost 1.72
* Protocol Buffers 3.7.1
* CMake 3.19 or newer
-* Visual Studio 2010 Professional or Higher
-* Windows SDK 8.1 (if building CPU rate control for the container executor)
-* zlib headers (if building native code bindings for zlib)
+* Visual Studio 2019
+* Windows SDK 8.1 (optional, if building CPU rate control for the container
executor)
+* Zlib (if building native code bindings for zlib)
Review Comment:
Done.
> Update build instructions for Windows using VS2019
> --------------------------------------------------
>
> Key: HADOOP-18506
> URL: https://issues.apache.org/jira/browse/HADOOP-18506
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, documentation
> Affects Versions: 3.4.0
> Environment: Windows 10
> Reporter: Gautham Banasandra
> Assignee: Gautham Banasandra
> Priority: Major
> Labels: pull-request-available
>
> With HADOOP-18133, we're finally able to build Hadoop on Windows using Visual
> Studio 2019. We now need to update the documentation with the latest
> instructions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
