[
https://issues.apache.org/jira/browse/HADOOP-18505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622794#comment-17622794
]
ASF GitHub Bot commented on HADOOP-18505:
-----------------------------------------
FuzzingTeam commented on code in PR #5065:
URL: https://github.com/apache/hadoop/pull/5065#discussion_r1002703817
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/erasurecode/TestCoderBase.java:
##########
@@ -224,13 +225,25 @@ protected ECChunk[] backupAndEraseChunks(ECChunk[]
dataChunks,
int idx = 0;
for (int i = 0; i < erasedDataIndexes.length; i++) {
- toEraseChunks[idx ++] = dataChunks[erasedDataIndexes[i]];
- dataChunks[erasedDataIndexes[i]] = null;
+ if (erasedDataIndexes[i] < dataChunks.length) {
+ toEraseChunks[idx ++] = dataChunks[erasedDataIndexes[i]];
+ dataChunks[erasedDataIndexes[i]] = null;
+ } else {
+ throw new HadoopIllegalArgumentException(
Review Comment:
@steveloughran, sorry I don't quite understand this. Is this also a public
API? I found that this is only being used in Test classes.
I have changed the exception type to IllegalArgumentException.
> ArrayIndexOutOfBoundsException in TestCoderBase.java
> ----------------------------------------------------
>
> Key: HADOOP-18505
> URL: https://issues.apache.org/jira/browse/HADOOP-18505
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.3.4
> Reporter: FuzzingTeam
> Priority: Major
> Labels: pull-request-available
>
> The code throws an unhandled ArrayIndexOutOfBoundsException in the method
> _backupAndEraseChunks_ of _TestCoderBase_ class when it tries to access the
> out of bound indexes in _dataChunks_ and _parityChunks_ array.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
