mkuchenbecker commented on code in PR #5071:
URL: https://github.com/apache/hadoop/pull/5071#discussion_r1003605313
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java:
##########
@@ -723,6 +723,49 @@ public boolean delete(String src, boolean recursive)
throws IOException {
}
}
+ // Create missing user home dirs for trash paths.
+ // We assume the router is running with super-user privilege (can create
+ // user home dir in /user dir).
+ private void createUserHomeForTrashPath(List<RemoteLocation> locations)
throws IOException {
+ List<RemoteLocation> missingUserHomes = new ArrayList<>();
+
+ // Identify missing trash roots
+ for(RemoteLocation loc: locations) {
Review Comment:
I would consider structuring this differently for readability / testability:
1. Map the original list of locations to a List of Home Directories. (i.e.
given a list, make another list is easily testable)
2. Filter the list to the list of locations that don't exist. (i.e. given a
list, make another list)
3. Create those directories that don't exist. (for each element in the list,
call function X)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
