steveloughran commented on code in PR #5082:
URL: https://github.com/apache/hadoop/pull/5082#discussion_r1007911489
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/oauth2/AzureADAuthenticator.java:
##########
@@ -168,12 +168,14 @@ public static AzureADToken getTokenFromMsi(final String
authEndpoint,
*/
public static AzureADToken getTokenUsingRefreshToken(
final String authEndpoint, final String clientId,
- final String refreshToken) throws IOException {
+ final String clientSecret, final String refreshToken) throws IOException
{
QueryParams qp = new QueryParams();
qp.add("grant_type", "refresh_token");
qp.add("refresh_token", refreshToken);
- if (clientId != null) {
Review Comment:
well, microsoft wrote that bit of the code. we can assume that they knew
what their oauth endpoint does, though i personally find that endpoint's
response to auth failures (200 + text/html message for humans) fairly suboptimal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
