cnauroth commented on code in PR #5090:
URL: https://github.com/apache/hadoop/pull/5090#discussion_r1008632148
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml:
##########
@@ -1660,14 +1660,18 @@
<name>yarn.app.mapreduce.client-am.ipc.max-retries</name>
<value>3</value>
<description>The number of client retries to the AM - before reconnecting
- to the RM to fetch Application Status.</description>
+ to the RM to fetch Application Status.
+ In other words, it is the ipc.client.connect.max.retries to be used during
+ reconnecting to the RM and fetching Application Status.</description>
Review Comment:
I think it's a good update, because it makes it clear that
`ipc.client.connect.max.retries` (the common property for controlling this in
Hadoop's RPC framework) is not actually in effect for this code path, and
instead there is another property, with a different default, taking the place
of `ipc.client.connect.max.retries`.
This also brings this property's documentation into alignment with other
similar properties, such as these from yarn-default.xml:
```
<property>
<description>When HA is enabled, the number of retries per
attempt to connect to a ResourceManager. In other words,
it is the ipc.client.connect.max.retries to be used during
failover attempts</description>
<name>yarn.client.failover-retries</name>
<value>0</value>
</property>
```
```
<property>
<description>When HA is enabled, the number of retries per
attempt to connect to a ResourceManager on socket timeouts. In other
words, it is the ipc.client.connect.max.retries.on.timeouts to be used
during failover attempts</description>
<name>yarn.client.failover-retries-on-socket-timeouts</name>
<value>0</value>
</property>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
