[
https://issues.apache.org/jira/browse/HADOOP-18517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628008#comment-17628008
]
ASF GitHub Bot commented on HADOOP-18517:
-----------------------------------------
cnauroth commented on code in PR #5103:
URL: https://github.com/apache/hadoop/pull/5103#discussion_r1012364164
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStream.java:
##########
@@ -745,6 +745,12 @@ byte[] getBuffer() {
return buffer;
}
+ @VisibleForTesting
+ public boolean isReadAheadEnabled() {
+ return readAheadEnabled;
+
Review Comment:
Please remove the blank line.
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsInputStreamContext.java:
##########
@@ -72,6 +74,13 @@ public AbfsInputStreamContext withTolerateOobAppends(
return this;
}
+ public AbfsInputStreamContext isReadAheadEnabled(
+ final boolean isReadAheadEnabled) {
+ this.isReadAheadEnabled = isReadAheadEnabled;
+ return this;
+ }
+
+
Review Comment:
Another extra blank linehere.
> ABFS: Add fs.azure.enable.readahead option to disable readahead
> ---------------------------------------------------------------
>
> Key: HADOOP-18517
> URL: https://issues.apache.org/jira/browse/HADOOP-18517
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/azure
> Affects Versions: 3.3.4
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> Add an option fs.azure.enable.readahead to allow the abfs readahead to be
> disabled.
> This has been shipping in cloudera releases, because workloads with heavy
> random IO don't always benefit from prefetching.
> Pulling this in to ASF hadoop allows for
> * everyone to experiment with/without prefetching
> * ability to disable prefetching if you have problems with it
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
