mccormickt12 commented on PR #4967: URL: https://github.com/apache/hadoop/pull/4967#issuecomment-1302808254
@steveloughran I can't comment on your long comment above, > Looking at the specification, I'm not sure that `getRootPath()` is the right name, given that the root dir is "/" everywhere -and very special (you can delete it and it is still there afterwards). (it defined in model.md) > > What about `getMountRoot()`, as that is clearer at what it is. The current name being proposed is `getEnclosingRoot` which I do think is more generic since its not just mount roots. As for the tests you listed, I have all of them somewhere except for > wrapped invocation is unchanged. I will work on this. I'm still not clear where all you want all these tests replicated to. For the below, im not sure what you are referring to. I see `AbstractFSContract` but that seems pretty bare, im not sure if thats what you are referring to or something else. > for all tests of the specification which are expected to be met by all filesystems -not just hdfs/viewfs- we need a contract test subclass of AbstractFSC -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
