[
https://issues.apache.org/jira/browse/HADOOP-18427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630130#comment-17630130
]
ASF GitHub Bot commented on HADOOP-18427:
-----------------------------------------
hadoop-yetus commented on PR #5118:
URL: https://github.com/apache/hadoop/pull/5118#issuecomment-1306518830
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 10m 37s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
|||| _ branch-3.3 Compile Tests _ |
| +1 :green_heart: | mvninstall | 40m 11s | | branch-3.3 passed |
| +1 :green_heart: | compile | 19m 15s | | branch-3.3 passed |
| +1 :green_heart: | checkstyle | 1m 13s | | branch-3.3 passed |
| +1 :green_heart: | mvnsite | 1m 49s | | branch-3.3 passed |
| +1 :green_heart: | javadoc | 1m 7s | | branch-3.3 passed |
| +1 :green_heart: | spotbugs | 2m 59s | | branch-3.3 passed |
| +1 :green_heart: | shadedclient | 28m 42s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 8s | | the patch passed |
| +1 :green_heart: | compile | 18m 21s | | the patch passed |
| +1 :green_heart: | javac | 18m 21s | | root generated 0 new + 1867
unchanged - 3 fixed = 1867 total (was 1870) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 1m 4s | | the patch passed |
| +1 :green_heart: | mvnsite | 1m 47s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 54s | | the patch passed |
| +1 :green_heart: | spotbugs | 2m 55s | | the patch passed |
| +1 :green_heart: | shadedclient | 28m 29s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 17m 55s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | asflicense | 1m 10s | | The patch does not
generate ASF License warnings. |
| | | 178m 37s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5118/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/5118 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 81a6ffc159e7 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4
01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-3.3 / d1551e903bdf82042e5c338722c01c756c9b90e6 |
| Default Java | Private Build-1.8.0_342-8u342-b07-0ubuntu1~18.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5118/1/testReport/ |
| Max. process+thread count | 1253 (vs. ulimit of 5500) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5118/1/console |
| versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0 https://yetus.apache.org |
This message was automatically generated.
> Improve ZKDelegationTokenSecretManager#startThead With recommended methods.
> ---------------------------------------------------------------------------
>
> Key: HADOOP-18427
> URL: https://issues.apache.org/jira/browse/HADOOP-18427
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common
> Affects Versions: 3.4.0
> Reporter: fanshilun
> Assignee: fanshilun
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> When reading the code, I found a deprecated method to use. In
> ZKDelegationTokenSecretManager#startThead, the code here uses the Curator's
> EnsurePath,
> But EnsurePath is deprecated, use the recommended method instead
> public class EnsurePath
> Deprecated.
> Since 2.9.0 - Prefer
> CuratorFramework.create().creatingParentContainersIfNeeded() or
> CuratorFramework.exists().creatingParentContainersIfNeeded()
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
