[
https://issues.apache.org/jira/browse/HADOOP-18246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631433#comment-17631433
]
ASF GitHub Bot commented on HADOOP-18246:
-----------------------------------------
ahmarsuhail commented on code in PR #5120:
URL: https://github.com/apache/hadoop/pull/5120#discussion_r1018626908
##########
hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md:
##########
@@ -1107,7 +1107,9 @@ options are covered in [Testing](./testing.md).
<name>fs.s3a.prefetch.block.size</name>
<value>8MB</value>
<description>
- The size of a single prefetched block of data.
+ The size of a single prefetched block of data.
+ Default value is 8 MB.
+ Lower limit for the block size is 1 byte.
Review Comment:
Sorry, I should have updated my comment. We discussed offline, you can
either revert this change completely, or change to just the following:
```suggestion
Decreasing this will increase the number of prefetches required, and may
negatively impact performance.
```
> Remove lower limit on s3a prefetching/caching block size
> --------------------------------------------------------
>
> Key: HADOOP-18246
> URL: https://issues.apache.org/jira/browse/HADOOP-18246
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.4.0
> Reporter: Daniel Carl Jones
> Assignee: Ankit Saurabh
> Priority: Minor
> Labels: pull-request-available
>
> The minimum allowed block size currently is {{PREFETCH_BLOCK_DEFAULT_SIZE}}
> (8MB).
> {code:java}
> this.prefetchBlockSize = intOption(
> conf, PREFETCH_BLOCK_SIZE_KEY,
> PREFETCH_BLOCK_DEFAULT_SIZE, PREFETCH_BLOCK_DEFAULT_SIZE);{code}
> [https://github.com/apache/hadoop/blob/3aa03e0eb95bbcb066144706e06509f0e0549196/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java#L487-L488]
> Why is this the case and should we lower or remove it?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
