slfan1989 commented on PR #4450: URL: https://github.com/apache/hadoop/pull/4450#issuecomment-1311901405
@zhengchenyu Thank you very much for your contribution! From my personal point of view, I think adding AsyncDispatcher and defining a state machine to implement functions is a bit over-engineered. @goiri Thank you very much for inviting me to help review the code! I read this pr code carefully and I found that the function described by this pr has been implemented, The PRs involved are as follows: 1.YARN-11290(#4846) 2.YARN-11323(#4954) In YARN-11290, we improved the `getApplicationsHomeSubCluster` method, mainly in 2 improvement points: 1. Allows to query the App based on the specified HomeSubCluster. 2. Currently this interface returns the number of apps in all sub-clusters, Added new configuration used to limit Query the number of apps, return 1000 apps by default. In YARN-11323, we optimized the method of cleaning expired application data. More detailed information can be found in (https://github.com/apache/hadoop/pull/4954) From my personal point of view, I think YARN-11290 and YARN-11323 are enough, welcome to continue the discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
