szilard-nemeth commented on PR #5116: URL: https://github.com/apache/hadoop/pull/5116#issuecomment-1315527067
> @ashutoshcipher do you have a specific way in mind? The behaviour change introduced in 1.21 was that if someone with a large UID creates some files and tries to use the lib with no BigNumberMode set to compress them, it throws an IllegalArgumentException, as opposed to setting the owner id/group to 0. Now to properly reproduce this we would need to create a file with a large enough user ID as owner, call the lib, and [let it copy](https://github.com/apache/commons-compress/blob/master/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveOutputStream.java?rgh-link-date=2022-11-14T17%3A36%3A24Z#L600) the tar details, but this all seems to me like testing an external lib in a unit test, not to mention that at this stage we're using the local file system, so no owner change is possible to non-existent large UID users. > > What we could do instead is to create a large enough file and test if the compress lib allows that in the header. What do you think? I do agree with @brumi1024, that it seems quite complicated to test this in the UT-scope, moreover as @brumi1024 mentioned this is more of a library testing and not testing how the FrameworkUploader behaves. In this case, I would be fine without adding a new UT case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
