slfan1989 commented on code in PR #5131: URL: https://github.com/apache/hadoop/pull/5131#discussion_r1023980706
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/store/impl/FederationStateStoreBaseTest.java: ########## @@ -879,7 +879,7 @@ public void testStoreNewMasterKey() throws Exception { } @Test - public void testGetMasterKeyByDelegationKey() throws YarnException, IOException { + public void testGetMasterKeyByDelegationKey() throws Exception { Review Comment: The exception thrown by the method signature, I will recover. In the process of writing JunitTest code, I used `curatorFramework.getData().forPath` method to get data from ZK. This method throws an `Exception`, so I modified the exception throwing code of the method signature. ``` /** * Commit the currently building operation using the given path * * @param path the path * @return operation result if any * @throws Exception errors */ public T forPath(String path) throws Exception; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org