tomscut commented on code in PR #5129: URL: https://github.com/apache/hadoop/pull/5129#discussion_r1027393176
########## hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java: ########## @@ -101,8 +103,24 @@ public class OfflineImageViewerPB { + " against image file. (XML|FileDistribution|\n" + " ReverseXML|Web|Delimited|DetectCorruption)\n" + " The default is Web.\n" + + "-addr <arg> Specify the address(host:port) to listen.\n" + + " (localhost:5978 by default). This option is\n" + + " used with Web processor.\n" + + "-maxSize <arg> Specify the range [0, maxSize] of file sizes\n" + + " to be analyzed in bytes (128GB by default).\n" + + " This option is used with FileDistribution processor.\n" + + "-step <arg> Specify the granularity of the distribution in bytes\n" + + " (2MB by default). This option is used\n" + + " with FileDistribution processor.\n" + + "-format Format the output result in a human-readable fashion rather\n" + + " than a number of bytes. (false by default).\n" + + " This option is used with FileDistribution processor.\n" + "-delimiter <arg> Delimiting string to use with Delimited or \n" + " DetectCorruption processor. \n" + + "-sp Whether to print Storage policy (default is false). \n" + + " Is used by Delimited processor only. \n" + + "-ec Whether to print Erasure coding policy (default is false). \n" Review Comment: nit: `Storage policy` -> `storage policy`, `Erasure coding policy` -> `erasure coding policy`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org