virajjasani commented on code in PR #5054:
URL: https://github.com/apache/hadoop/pull/5054#discussion_r1032874644


##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3APrefetchingInputStream.java:
##########
@@ -294,4 +294,34 @@ public void testStatusProbesAfterClosingStream() throws 
Throwable {
 
   }
 
+  @Test
+  public void testCacheFileExistence() throws Throwable {

Review Comment:
   Sorry, I had to remove this change in the latest revision.
   
   The problem could arise with the file cleanup: we would not know which exact 
cache file was created by this test, meaning what if another test (with 
-Dprefetch option) running in parallel also creates a new cache file and we 
remove it as part of this test?
   
   Edit: This is now taken care of in the latest revision.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to